Re: [PATCH] Use vtable for eww-bookmarks

[Thierry Volpiatto]

Stefan Kangas <stefankangas@gmail.com> writes:

> Sebastián Monía <sebastian@sebasmonia.com> writes:
>
>> Stefan Kangas <stefankangas@gmail.com> writes:
>>> Sebastián Monía <sebastian@sebasmonia.com> writes:
>>>
>>>> lack of movement in this thread which is probably a
>>>> gauge for interest in the change.
>>>
>>> I wouldn't necessarily interpret a lack of replies or a long
>>> turnaround time as disinterest[...] keep in mind that all of us are
>>> volunteers, and do this in our free time too.
>>
>> Yes, this is why I said "probably". Heck, even when I made updates to the
>> patch, sometimes I took a long time to get to it :)
>>
>> But since Eli's latest ping and the subsequent conversation about
>> deprecating EWW's own bookmark mechanism, I am thinking that maybe this
>> isn't worth our collective time. Again, coming from a practical place!
>
> Is there any reason not to merge your latest patch while we wait for
> deprecating EWW's bookmarks to happen?  Adam says that it's already an
> improvement, and I'd agree if it means replacing bespoke code with using
> vtable.  From a cursory look, I don't see anything controversial in
> there.
>
> Adam also asked for people to speak up if they object to the patch over
> a week ago, and no one did.

If you plan to move to emacs bookmarks, I see no reasons to use vtable,
it will complicate conversion of eww bookmarks to bookmarks which is
actually trivial. 

-- 
Thierry