Re: [PATCH] Use vtable for eww-bookmarks

[Sebastián Monía]

Stefan Kangas <stefankangas@gmail.com> writes:
> Sebastián Monía <sebastian@sebasmonia.com> writes:
>
>> Thierry Volpiatto <thievol@posteo.net> writes:
>>> Stefan Kangas <stefankangas@gmail.com> writes:
>>>
>>>> Is there any reason not to merge your latest patch while we wait for
>>>> deprecating EWW's bookmarks to happen?  Adam says that it's already an
>>>> improvement, and I'd agree if it means replacing bespoke code with using
>>>> vtable.  From a cursory look, I don't see anything controversial in
>>>> there.
>>>>
>>>> Adam also asked for people to speak up if they object to the patch over
>>>> a week ago, and no one did.
>>>
>>> If you plan to move to emacs bookmarks, I see no reasons to use vtable,
>>> it will complicate conversion of eww bookmarks to bookmarks which is
>>> actually trivial.
>>
>> Adam already hinted it in his reply, but this patch doesn't change the
>> internal representation of EWW-bookmarks.
>>
>> A minor update, I have started using M-n and M-b and relying on the
>> bookmark order to navigate them. We don't have any statistics, of
>> course, but I suspect the feature is largely unknown.
>> It's interesting. I suspect I found it useful because I don't use a feed
>> reader, most people would use elfeed/newsticker instead.
>> It is also relatively easy to write a similar command using the more
>> generic bookmarks.
>
> Could you please resend the latest version of the patch?

Attached! This version was sent December 12.

0001-Use-vtable-in-eww-list-bookmarks.patch
Description: Last path (Dec 12)

-- 
Sebastián Monía
https://site.sebasmonia.com/