emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Use vtable for eww-bookmarks


From: Sebastián Monía
Subject: Re: [PATCH] Use vtable for eww-bookmarks
Date: Tue, 28 Jan 2025 23:12:21 -0500
User-agent: Gnus/5.13 (Gnus v5.13)

Thanks for detecting these bugs, Jim!

Jim Porter <jporterbugs@gmail.com> writes:
> 1. Killing a bookmark works, but yanking at the end of the buffer
> produces the following error:

This happened because the reverting function must be called with point
inside the vtable instance. Modified so that in the special case that
point is at the end of the buffer after removing the row, we move one
line up.

> 2. Killing the last bookmark in the buffer produces this error:

In this case, I will handle adding to the end of the list as a special
case. Once again, with point outside the vtable, a lot of vtable calls
don't work . And then we also have to move point inside the table to
revert it, just like in #1.

Attached the patch with these corrections.

Thank you,
Seb

Attachment: 0001-Use-vtable-in-eww-list-bookmarks.patch
Description: Use vtable for bookmarks


-- 
Sebastián Monía
https://site.sebasmonia.com/

reply via email to

[Prev in Thread] Current Thread [Next in Thread]