Re: [PATCH] Use vtable for eww-bookmarks

[Sebastián Monía]

I realized this morning I compared numbers using 'equal' instead of = in
some of the new code.
Attached updated patch :)

0001-Use-vtable-in-eww-list-bookmarks.patch
Description: Use vtable for eww-bookmarks

Sebastián Monía <sebastian@sebasmonia.com> writes:
> Thanks for detecting these bugs, Jim!
>
> Jim Porter <jporterbugs@gmail.com> writes:
>> 1. Killing a bookmark works, but yanking at the end of the buffer
>> produces the following error:
>
> This happened because the reverting function must be called with point
> inside the vtable instance. Modified so that in the special case that
> point is at the end of the buffer after removing the row, we move one
> line up.
>
>> 2. Killing the last bookmark in the buffer produces this error:
>
> In this case, I will handle adding to the end of the list as a special
> case. Once again, with point outside the vtable, a lot of vtable calls
> don't work . And then we also have to move point inside the table to
> revert it, just like in #1.
>
> Attached the patch with these corrections.
>
> Thank you,
> Seb

-- 
Sebastián Monía
https://site.sebasmonia.com/