Re: [PATCH] Use vtable for eww-bookmarks

[Sebastián Monía]

Thanks Jim, I will correct these.

On Tue, Jan 21, 2025, at 10:50 PM, Jim Porter wrote:
> On 1/21/2025 6:36 PM, Sebastián Monía wrote:
> > Attached! This version was sent December 12.
> 
> Thanks for reposting. I ran with this and found the following issues.
> 
> 1. Killing a bookmark works, but yanking at the end of the buffer 
> produces the following error:
> 
> Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil)
>    seq-subseq(((:url "https://www.fsf.org/"; :title "Front Page — Free 
> Software Foundation — working together for free software" :time "Tue Jan 
> 21 19:48:33 2025")) nil)
>    eww-bookmark-yank()
>    funcall-interactively(eww-bookmark-yank)
>    command-execute(eww-bookmark-yank)
> 
> 
> 
> 2. Killing the last bookmark in the buffer produces this error:
> 
> Debugger entered--Lisp error: (cl-no-applicable-method 
> vtable-objects-function nil)
>    signal(cl-no-applicable-method (vtable-objects-function nil))
>    cl-no-applicable-method(#s(cl--generic :name vtable-objects-function 
> :dispatches ((0 #s(cl--generic-generalizer :name 
> eieio--generic-generalizer :priority 50 :tagcode-function 
> cl--generic-struct-tag :specializers-function #f(compiled-function (tag 
> &rest _) #<bytecode 0x137071fd5144f137>)) #s(cl--generic-generalizer 
> :name cl--generic-t-generalizer :priority 0 :tagcode-function 
> #f(compiled-function (name &rest _) #<bytecode 0x111a2082463a1535>) 
> :specializers-function #f(compiled-function (tag &rest _) #<bytecode 
> -0x1a05678245d32db5>)))) :method-table (#s(cl--generic-method 
> :specializers (vtable) :qualifiers nil :call-con nil :function 
> #f(compiled-function (this) "Retrieve the slot `objects-function' from 
> an object of class `vtable'." #<bytecode -0x65b654f1e7958ff>))) :options 
> nil) nil)
>    apply(cl-no-applicable-method #s(cl--generic :name 
> vtable-objects-function :dispatches ((0 #s(cl--generic-generalizer :name 
> eieio--generic-generalizer :priority 50 :tagcode-function 
> cl--generic-struct-tag :specializers-function #f(compiled-function (tag 
> &rest _) #<bytecode 0x137071fd5144f137>)) #s(cl--generic-generalizer 
> :name cl--generic-t-generalizer :priority 0 :tagcode-function 
> #f(compiled-function (name &rest _) #<bytecode 0x111a2082463a1535>) 
> :specializers-function #f(compiled-function (tag &rest _) #<bytecode 
> -0x1a05678245d32db5>)))) :method-table (#s(cl--generic-method 
> :specializers (vtable) :qualifiers nil :call-con nil :function 
> #f(compiled-function (this) "Retrieve the slot `objects-function' from 
> an object of class `vtable'." #<bytecode -0x65b654f1e7958ff>))) :options 
> nil) nil)
>    #f(compiled-function (&rest args) #<bytecode 0x159c15a915096a8f>)(nil)
>    apply(#f(compiled-function (&rest args) #<bytecode 
> 0x159c15a915096a8f>) nil nil)
>    vtable-objects-function(nil)
>    vtable-revert-command()
>    eww-bookmark-kill()
>    funcall-interactively(eww-bookmark-kill)
>    command-execute(eww-bookmark-kill)
> 
>