[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Explain a bit more on how to configure language server in Eg
From: |
João Távora |
Subject: |
Re: [PATCH] Explain a bit more on how to configure language server in Eglot's manual |
Date: |
Thu, 16 Mar 2023 00:09:55 +0000 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Michael Eliachevitch <m.eliachevitch@posteo.de> writes:
> I would be fine with you editing the patch if you find some minor
> things to improve or have a better idea for the example. Git commits
> can have co-authors (this is what github does when you accept
> suggestions from reviewers), but not sure how the typical workflows
> are on emacs-devel (I just recently joined to keep up-to-date with
> recent developments). Or should the patch submitter must aggregate all
> suggestions into a final patch themselves?
Separate patches is fine, especially if your're proposing different
functional changes. Big salads less fine, but also accepted. I think
most commiters know how to split patches. Here, I didn't because I was
lazy, and it's a very small change.
I've pushed your patch to Emacs 29 with a tweak to the commit message
and a whitespace change, so I didn't add "Co-authored-by: João Távora
<...>" like I sometimes do.
> I'll try that soon. This patch changes just a couple of lines of
> documentation, so I hope it's fine for now. Slowly I'm figuring out
> this mailing list workflow and with the copyright assignment, there
> would be no hurdles for larger contributions to Emacs in the future :)
It's just email: there's much less to figure out than people think.
João
- Re: [SPAM UNSURE] Explain a bit more on how to configure language server in Eglot's manual, (continued)
- Re: [SPAM UNSURE] Explain a bit more on how to configure language server in Eglot's manual, João Távora, 2023/03/09
- Re: [SPAM UNSURE] Explain a bit more on how to configure language server in Eglot's manual, Yuan Fu, 2023/03/10
- Re: Explain a bit more on how to configure language server in Eglot's manual, Michael Eliachevitch, 2023/03/14
- Re: Explain a bit more on how to configure language server in Eglot's manual, João Távora, 2023/03/14
- Re: [PATCH] Explain a bit more on how to configure language server in Eglot's manual, Michael Eliachevitch, 2023/03/14
- Re: [PATCH] Explain a bit more on how to configure language server in Eglot's manual, Michael Eliachevitch, 2023/03/15
- Re: [PATCH] Explain a bit more on how to configure language server in Eglot's manual, Eli Zaretskii, 2023/03/15
- Re: [PATCH] Explain a bit more on how to configure language server in Eglot's manual, Michael Eliachevitch, 2023/03/15
- Re: [PATCH] Explain a bit more on how to configure language server in Eglot's manual, João Távora, 2023/03/15
- Re: [PATCH] Explain a bit more on how to configure language server in Eglot's manual, Michael Eliachevitch, 2023/03/15
- Re: [PATCH] Explain a bit more on how to configure language server in Eglot's manual,
João Távora <=
Re: Explain a bit more on how to configure language server in Eglot's manual, Augusto Stoffel, 2023/03/06
- Re: Explain a bit more on how to configure language server in Eglot's manual, João Távora, 2023/03/06
- Re: Explain a bit more on how to configure language server in Eglot's manual, Augusto Stoffel, 2023/03/06
- Re: Explain a bit more on how to configure language server in Eglot's manual, João Távora, 2023/03/06
- Re: Explain a bit more on how to configure language server in Eglot's manual, Pedro Andres Aranda Gutierrez, 2023/03/06
- Re: Explain a bit more on how to configure language server in Eglot's manual, João Távora, 2023/03/06
- Re: Explain a bit more on how to configure language server in Eglot's manual, Augusto Stoffel, 2023/03/06
- Re: Explain a bit more on how to configure language server in Eglot's manual, João Távora, 2023/03/06
- Re: Explain a bit more on how to configure language server in Eglot's manual, Augusto Stoffel, 2023/03/06
- Re: Explain a bit more on how to configure language server in Eglot's manual, João Távora, 2023/03/06