Re: [PATCH] Explain a bit more on how to configure language server in Eglot's manual

[João Távora]

Michael Eliachevitch <m.eliachevitch@posteo.de> writes:

> Thanks Eli, I incorporated your comments into v2 of the patch attached
> below.

Thanks Michael and Eli.

I'll push the patch soon it with a

  Copyright-paperwork-exempt: Yes

cookie, since this seems to fall under the "trivial" basket, but you
should probably get a FSF copyright assignment for future contributions.

Minor comments below.


>  (setq-default eglot-workspace-configuration
> @@ -1241,17 +1241,21 @@ JSONRPC objects in Elisp
>  For representing the JSON leaf values @code{true}, @code{false},
>  @code{null} and @code{@{@}}, you can use the Lisp values @code{t},
>  @code{:json-false}, @code{nil}, and @code{eglot-@{@}}, respectively.
> +JSON arrays are represented as lisp vectors surrounded by square
>  brackets

"Lisp" should be capitalized (pedantically, "Elisp", since vectors in
other dialects have different read syntax, but Lisp is fine)


>  (:pylsp (:plugins (:jedi_completion (:include_params t
> -                                             :fuzzy t)
> -                           :pylint (:enabled :json-false)))
> +                                     :fuzzy t)
> +                   :pylint (:enabled :json-false
> +                            :args ["--disable" "C0103"])))

Hmmm.  I don't use "pylint" but what sense does it make to disable it
entirely (supposedly, that's what :enabled :json-false does) and then
_also_ pass args to it.  Should we just enable it?  This is all pretend,
of course.  But shouldn't it make more sense?

João