Re: [lmi] Wrong wxFlexGridSizer usage in about_dialog.cpp

[Greg Chicares]

On 2010-01-14 22:37Z, Vadim Zeitlin wrote:
> 
>  Thanks! Looking at the diff with my version, the main difference between
> my and your version is the removal of this comment from my patch:
> 
> @@ -69,13 +70,6 @@ int AboutDialog::ShowModal()
>          );
>      html_window->SetBorders(0);
>      html_window->SetPage(license_notices_as_html());
> -
> -    // Size the window to exactly fit its contents. We assume here that this 
> is
> -    // reasonable, in particular that the HTML is short enough to fit 
> entirely
> -    // on the screen. If this is not the case, we'd break the dialog layout 
> by
> -    // requesting that one of its children be allocated more size than is
> -    // available to the entire dialog itself, so if this ever becomes a 
> concern
> -    // we should explicitly compare the size of this window with display 
> size.
>      int width =
>              html_window->GetInternalRepresentation()->GetWidth()
>          +   wxSystemSettings::GetMetric(wxSYS_VSCROLL_X)
> 
> 
> IMO it's not exactly obvious so I think the comment could be useful. I
> don't know if you disagree with this entirely or just left it out
> unintentionally.

I think we may change the code that it documents. Film at eleven.

>  Also, there still remains unneeded, IMO, use of wxFlexGridSizer where a
> simple wxBoxSizer would have been enough. So what do you think of this
> patch [fragment]:

$Id: about_dialog.cpp 4738 2010-01-18 00:04:53Z chicares $