emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: New multi-command facility displays in the wrong echo area.


From: Eli Zaretskii
Subject: Re: New multi-command facility displays in the wrong echo area.
Date: Fri, 16 Oct 2020 10:19:49 +0300

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Eli Zaretskii <eliz@gnu.org>,  acm@muc.de,  emacs-devel@gnu.org
> Date: Wed, 14 Oct 2020 18:51:09 -0400
> 
> > (or (eq (window-frame) (window-frame (active-minibuffer-window)))
> >     (eq (frame-parameter (window-frame (active-minibuffer-window)) 
> > 'minibuffer) 'only)))
> 
> I think it would be cleaner (i.e. better express the intent) if it was
> written something like
> 
>     (eq (mini-window-of (selected-frame))
>         (active-minibuffer-window))
> 
> which may require writing `mini-window-of` first (and choosing a better
> name for it along the way).

Yes, I've used let* to avoid calling active-minibuffer-window (and
other functions) more than once.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]