[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: AC_FUNC_LSTAT_FOLLOWS_SLASHED_SYMLINK
From: |
Paul Eggert |
Subject: |
Re: AC_FUNC_LSTAT_FOLLOWS_SLASHED_SYMLINK |
Date: |
Mon, 17 Sep 2001 15:21:18 -0700 (PDT) |
> From: "Tim Van Holder" <address@hidden>
> Date: Mon, 17 Sep 2001 22:15:47 +0200
>
> Is that OK to commit?
I still see some problems.
Don't you need an AC_REQUIRE([AC_PROG_LN_S])?
Why do you mention the file 'conftsym.exe'? That looks like a typo.
ac_cv_func_lstat_dereferences_slashed_symlink
is left uninitialized when $LN_S is not 'ln -s'.
How about if you simplify the code with something like this?
rm -f conftest.sym conftest.file
if test "$LN_S" = "ln -s" && ln -s conftest.file conftest.sym; then
...
Also you need a ChangeLog entry describing this change only.
> I also noticed that _AC_FUNC_FORK contains an 8-bit character (ΓΌ/u:)
> in a C comment. Are there still compilers/preprocessors around that
> might choke on that (I doubt it, but I thought I'd check)?
Yes, possibly, in some locales, e.g. shift-JIS. It's better to remove
stuff like that.
(no subject), Tim Van Holder, 2001/09/16
- Re: (no subject), Akim Demaille, 2001/09/17
- Re: (no subject), Tim Van Holder, 2001/09/17
- Re: AC_FUNC_LSTAT_FOLLOWS_SLASHED_SYMLINK,
Paul Eggert <=
- Re: AC_FUNC_LSTAT_FOLLOWS_SLASHED_SYMLINK, Tim Van Holder, 2001/09/18
- Re: AC_FUNC_LSTAT_FOLLOWS_SLASHED_SYMLINK, Akim Demaille, 2001/09/19
- Re: AC_FUNC_LSTAT_FOLLOWS_SLASHED_SYMLINK, Tim Van Holder, 2001/09/20
- Re: AC_FUNC_LSTAT_FOLLOWS_SLASHED_SYMLINK, Akim Demaille, 2001/09/20
- Re: AC_FUNC_LSTAT_FOLLOWS_SLASHED_SYMLINK, Tim Van Holder, 2001/09/20
- Re: AC_FUNC_LSTAT_FOLLOWS_SLASHED_SYMLINK, Akim Demaille, 2001/09/20
(no subject), Tim Van Holder, 2001/09/16