autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: (no subject)


From: Akim Demaille
Subject: Re: (no subject)
Date: 17 Sep 2001 11:22:19 +0200
User-agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Artificial Intelligence)

I'd like to have Paul and Jim's opinions on this.

| 2001-09-16  Tim Van Holder  <address@hidden>
|       * lib/autoconf/functions.m4: (AC_FUNC_GETPGRP) Don't rely on
|       setpgrp() being present.
|       (AC_FUNC_LSTAT_FOLLOWS_SLASHED_SYMLINK): Use conf$$ instead of
|       conftest for test files.  Clean up after DJGPP's 'ln -s' (which
|       creates conf$$.exe).

I don't understand why you moved to $$: we never supported concurrent
executions of configure in a single dir, so it looks like gratuitous
obfuscation to me.

| Index: lib/autoconf/functions.m4
| ===================================================================
| RCS file: /cvs/autoconf/lib/autoconf/functions.m4,v
| retrieving revision 1.46
| diff -u -r1.46 functions.m4
| --- lib/autoconf/functions.m4 2001/08/22 06:24:46     1.46
| +++ lib/autoconf/functions.m4 2001/09/16 09:33:14
| @@ -612,6 +612,12 @@
|  int     pg1, pg2, pg3, pg4;
|  int     ng, np, s, child;
|  
| +/* Some systems lack process groups and setpgrp(), but do have getpgrp().
| +   Don't allow the lack of setpgrp() to get in our way. */
| +#ifndef HAVE_SETPGRP
| +void setpgrp(int a, int b) { }
| +#endif
| +
|  int
|  main ()
|  {
| @@ -657,7 +663,8 @@
|  # prototypes (AC_COMPILE), and if the compiler is of no help, try a runtime
|  # test.
|  AC_DEFUN([AC_FUNC_GETPGRP],
| -[AC_CACHE_CHECK(whether getpgrp takes no argument, ac_cv_func_getpgrp_void,
| +[AC_CHECK_FUNCS(getpgrp setpgrp)
| +AC_CACHE_CHECK(whether getpgrp takes no argument, ac_cv_func_getpgrp_void,
|  [# Use it with a single arg.
|  AC_COMPILE_IFELSE([AC_LANG_PROGRAM([AC_INCLUDES_DEFAULT], [getpgrp (0);])],
|                    [ac_func_getpgrp_1=yes],
| @@ -692,15 +699,15 @@
|  [AC_CACHE_CHECK(
|         [whether lstat dereferences a symlink specified with a trailing 
slash],
|         [ac_cv_func_lstat_dereferences_slashed_symlink],
| -[rm -f conftest.sym conftest.file
| -echo >conftest.file
| -if ln -s conftest.file conftest.sym; then
| +[rm -f conf$$ conf$$.exe conf$$.file
| +echo >conf$$.file
| +if ln -s conf$$.file conf$$ && test ! -f conf$$.exe; then
|    AC_RUN_IFELSE([AC_LANG_PROGRAM([AC_INCLUDES_DEFAULT],
|      [struct stat sbuf;
|       /* Linux will dereference the symlink and fail.
|          That is better in the sense that it means we will not
|          have to compile and use the lstat wrapper.  */
| -     exit (lstat ("conftest.sym/", &sbuf) ? 0 : 1);])],
| +     exit (lstat ("conf$$/", &sbuf) ? 0 : 1);])],
|                  [ac_cv_func_lstat_dereferences_slashed_symlink=yes],
|                  [ac_cv_func_lstat_dereferences_slashed_symlink=no],
|                  [ac_cv_func_lstat_dereferences_slashed_symlink=no])
| @@ -709,7 +716,7 @@
|    # have an lstat function.
|    ac_cv_func_lstat_dereferences_slashed_symlink=no
|  fi
| -rm -f conftest.sym conftest.file
| +rm -f conf$$ conf$$.exe conf$$.file
|  ])
|  
|  test $ac_cv_func_lstat_dereferences_slashed_symlink = yes &&



reply via email to

[Prev in Thread] Current Thread [Next in Thread]