wget-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: wget2 | * configure.ac: Remove redundant sanitizer warnings (!506)


From: Darshit Shah (@darnir)
Subject: Re: wget2 | * configure.ac: Remove redundant sanitizer warnings (!506)
Date: Sun, 24 Apr 2022 10:24:47 +0000



Darshit Shah commented on a discussion on configure.ac: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/506#note_921942907

>    # additional clang options, from OSS-Fuzz (20.12.2019)
> -  gl_WARN_ADD([-fsanitize=integer])
> -  gl_WARN_ADD([-fsanitize=array-bounds])
> -  gl_WARN_ADD([-fsanitize=builtin])
> -  gl_WARN_ADD([-fsanitize=float-divide-by-zero])
> -  gl_WARN_ADD([-fsanitize=function])
> -  gl_WARN_ADD([-fsanitize=integer-divide-by-zero])
> -  gl_WARN_ADD([-fsanitize=object-size])
> -  gl_WARN_ADD([-fsanitize=return])
> -  gl_WARN_ADD([-fsanitize=returns-nonnull-attribute])
> -  gl_WARN_ADD([-fsanitize=shift])
> -  gl_WARN_ADD([-fsanitize=signed-integer-overflow])
> -  gl_WARN_ADD([-fsanitize=unsigned-integer-overflow])
> -  gl_WARN_ADD([-fsanitize=unreachable])
> -  gl_WARN_ADD([-fsanitize=vla-bound])
> -  gl_WARN_ADD([-fsanitize=vptr])

I'd leave these as-is unless they're causing an issue somewhere. While today, 
GCC and Clang agree on all the options for `-fsanitize=undefined`, there is no 
reason to believe that it will remain this way. Thus, being explicit will be 
better for us.

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/506#note_921942907
You're receiving this email because of your account on gitlab.com.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]