wget-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: wget2 | * configure.ac: Remove redundant sanitizer warnings (!506)


From: @rockdaboot
Subject: Re: wget2 | * configure.ac: Remove redundant sanitizer warnings (!506)
Date: Fri, 22 Apr 2022 17:39:38 +0000



Tim Rühsen commented on a discussion on configure.ac: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/506#note_921350117

> +  if test "$CCNAME" = "clang"; then
> +    gl_WARN_ADD([-fsanitize=unsigned-integer-overflow])
> +    gl_WARN_ADD([-fsanitize=implicit-conversion])
> +    gl_WARN_ADD([-fsanitize=local-bounds])
> +    gl_WARN_ADD([-fsanitize=nullability])
> +  fi
> +
> +  if test "$CCNAME" = "gcc"; then
> +    gl_WARN_ADD([-fsanitize=float-cast-overflow])
> +  fi
>  fi
>  
>  if test "$gl_cc_sanitize_asan" = yes; then
>    gl_WARN_ADD([-fsanitize=address])
>    gl_WARN_ADD([-fsanitize=leak])
> -  gl_WARN_ADD([-fsanitize=nonnull-attribute])

Out of interest, for which gcc version did you check ?
We should make sure that this is true for the gcc version used in the CI runner 
and above. Let's define older versions as "out of scope".
Maybe we should add a comment about the minimum gcc and clang versions 
supported (saying that older versions have not been tested with).

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/506#note_921350117
You're receiving this email because of your account on gitlab.com.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]