Re: wget2 | * configure.ac: Remove redundant sanitizer warnings (!506)

[Avinash Sonawane (@rootkea)]

Avinash Sonawane commented on a discussion on configure.ac: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/506#note_921393837

> +  if test "$CCNAME" = "clang"; then
> +    gl_WARN_ADD([-fsanitize=unsigned-integer-overflow])
> +    gl_WARN_ADD([-fsanitize=implicit-conversion])
> +    gl_WARN_ADD([-fsanitize=local-bounds])
> +    gl_WARN_ADD([-fsanitize=nullability])
> +  fi
> +
> +  if test "$CCNAME" = "gcc"; then
> +    gl_WARN_ADD([-fsanitize=float-cast-overflow])
> +  fi
>  fi
>  
>  if test "$gl_cc_sanitize_asan" = yes; then
>    gl_WARN_ADD([-fsanitize=address])
>    gl_WARN_ADD([-fsanitize=leak])
> -  gl_WARN_ADD([-fsanitize=nonnull-attribute])

Ah, I don't see a comment about the minimum gcc and clang versions supported is 
necessary. If an old version compiler doesn't support a particular flag then it 
anyways doesn't get added in CFLAGS. `./configure` ensures that. So I see no 
issue building with an older compiler.

Those with newer compiler will get new flags and the ones with old compiler 
won't but both can build wget2.

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/506#note_921393837
You're receiving this email because of your account on gitlab.com.