wget-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: wget2 | * configure.ac: Remove redundant sanitizer warnings (!506)


From: Avinash Sonawane (@rootkea)
Subject: Re: wget2 | * configure.ac: Remove redundant sanitizer warnings (!506)
Date: Fri, 22 Apr 2022 18:34:11 +0000



Avinash Sonawane commented on a discussion on configure.ac: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/506#note_921387409

>    # additional clang options, from OSS-Fuzz (20.12.2019)
> -  gl_WARN_ADD([-fsanitize=integer])
> -  gl_WARN_ADD([-fsanitize=array-bounds])
> -  gl_WARN_ADD([-fsanitize=builtin])
> -  gl_WARN_ADD([-fsanitize=float-divide-by-zero])
> -  gl_WARN_ADD([-fsanitize=function])
> -  gl_WARN_ADD([-fsanitize=integer-divide-by-zero])
> -  gl_WARN_ADD([-fsanitize=object-size])
> -  gl_WARN_ADD([-fsanitize=return])
> -  gl_WARN_ADD([-fsanitize=returns-nonnull-attribute])
> -  gl_WARN_ADD([-fsanitize=shift])
> -  gl_WARN_ADD([-fsanitize=signed-integer-overflow])
> -  gl_WARN_ADD([-fsanitize=unsigned-integer-overflow])
> -  gl_WARN_ADD([-fsanitize=unreachable])
> -  gl_WARN_ADD([-fsanitize=vla-bound])
> -  gl_WARN_ADD([-fsanitize=vptr])

TBH, I didn't. I just went through the clang and gcc sanitizer docs.

But looking now, it seems they are [explicitly adding every undefined 
flag](https://github.com/google/oss-fuzz/blob/c9d66436e1fef1fe27dc8483b273c7d51a03099f/infra/base-images/base-builder/Dockerfile#L78)
 instead of simply doing `-fsanitize=undefined` and adding couple more which 
are not part of `-fsanitize=undefined`. I wonder why...

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/506#note_921387409
You're receiving this email because of your account on gitlab.com.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]