Code review and commits to the official repository

[Rui Batista]

Hi,
Qua, 2010-08-11 ?s 15:36 -0500, William Hubbs escreveu:
> On Wed, Aug 11, 2010 at 09:12:18PM +0200, Tomas Cerha wrote:
> > Dne 11.8.2010 20:24, William Hubbs napsal(a):
> > > On Wed, Aug 11, 2010 at 03:51:38PM +0200, Tomas Cerha wrote:
> > >> Dne 10.8.2010 17:39, Chris Brannon napsal(a):
> > >>> This sounds good.
> > >>> How about signed-off-by lines?  Should the reviewer add one before
> > >>> committing?  I like them, myself, because it is obvious who reviewed
> > >>> the patch.
> > >>
> > >> Good point.  I haven't used that before, but it looks good to me.  Maybe
> > >> the "Reviewed-by" tag would be more appropriate for us, according to:
> > >>
> > >> http://gerrit.googlecode.com/svn/documentation/2.0/user-signedoffby.html
> > > 
> > > I'm not sure how you do a Reviewed-by tag in git, but Signed-off-by is
> > > as easy as adding a -s option to "git commit" or "git am".
> > 
> > If someone finds out, I'd be interested to know as well...  Tomas
> 
> I'm not sure that the wording really matters; "signed-off-by" is fine as
> far as I am concerned, because that indicates that you are approving
> the commit.
> 
+1.

Rui Batista
> William
> 
> _______________________________________________
> Speechd mailing list
> Speechd at lists.freebsoft.org
> http://lists.freebsoft.org/mailman/listinfo/speechd

Rui Batista
E-mail/googletalk: ruiandrebatista (at) gmail (dot) com
MSN/WLM: ruiandrebatista (at) hotmail (dot) com (don't send mail to this
one)
Skype: ruiandrebatista
twitter: http://twitter.com/ragb
weblog: http://unreliabledevice.net