[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Code review and commits to the official repository
From: |
Tomas Cerha |
Subject: |
Code review and commits to the official repository |
Date: |
Wed, 11 Aug 2010 15:51:38 +0200 |
Dne 10.8.2010 17:39, Chris Brannon napsal(a):
> Hynek Hanke wrote:
>> A piece of code (a patch on the mailing list, a branch
>> from a private Git repository etc.) cannot be submitted
>> to the repository by the original developer himself,
>> but must be first submitted for review. The reviewer
>> will push it to the official Git repository.
>
> This sounds good.
> How about signed-off-by lines? Should the reviewer add one before
> committing? I like them, myself, because it is obvious who reviewed
> the patch.
Good point. I haven't used that before, but it looks good to me. Maybe
the "Reviewed-by" tag would be more appropriate for us, according to:
http://gerrit.googlecode.com/svn/documentation/2.0/user-signedoffby.html
Best regards, Tomas
Code review and commits to the official repository, Luke Yelavich, 2010/08/10
Code review and commits to the official repository, Tomas Cerha, 2010/08/11
Code review and commits to the official repository, Andrei Kholodnyi, 2010/08/11