lmi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [lmi] xsl changes in cvs HEAD


From: Murphy, Kimberly
Subject: RE: [lmi] xsl changes in cvs HEAD
Date: Wed, 25 Jul 2007 11:58:03 -0400

Evgeniy Tarassov wrote:
> On 7/23/07, Murphy, Kimberly <address@hidden> wrote:
> > Evgeniy Tarassov wrote:
> > > On 7/13/07, Murphy, Kimberly 
> <address@hidden> wrote:
> >
> > > > 2 - On the offshore_private_placement.xsl, the heading 'Net
> > > Crediting
> > > > Rate' is not centered over the columns 'Sep Acct' and 'Gen
> > > Acct'. This
> > > > was corrected for the nasd.xsl file but inadvertently 
> was missed for
> > > > offshore.
> > >
> > > Fixed. Thank you for discovering the inconsistency!
> >
> > While the two *.xsl files are now consistent, they are both 
> incorrect.
> > The nasd.xsl was correct with lmi-20070625T1908Z (revision 
> 1.56). The
> > 'generic-table-header' template does not get used in this 
> instance but
> > instead a customize table header does. Please change both.
> 
> The patch (below) fixes the following:
> - in nasd.xsl properly center 'Net Crediting Rate' over 'Sep Acct' and
> 'Gen Acct'
> - in nasd.xsl fixes the incorrect row-spanning of 'Gen Acct'
> - in offshore_private_placement.xsl uses custom table header 
> to match nasd.xsl
> - in both adds an extra (empty and invisible) column between 'End of
> Year Age' and 'Net Crediting Rate' so that the cell blue border does
> not strike into the cell text

I tested and confirmed the patch fixes the issues very nicely in both
the nasd.xsl and offshore_private_placement.xsl.

> Since the custom header in offshore_private_placement is a copy/paste
> of the corresponding table header from nasd.xsl it should be
> refactored into fo_common.xsl and used in both 'nasd.xsl' and
> 'offshore_private_placement.xsl'. For the sake of readability of the
> patch I have not moved the code into fo_common.xsl. Once the patch is
> validated I'll do that before committing.

Once fo_common.xsl has been refactored, I will be happy to test the 
patch before it's committed.

Additionally, I observed a couple spacing issues while testing that 
should be fixed. 

First, on the illustration_reg.xsl, offshore_private_placement.xsl, 
and nasd.xsl, under the 'Important Tax Disclosure' section, the first 
sentence has a space before the period after the word "Code" when 
the illustration is 'not' a MEC.  

Second, on the offshore_private_placement.xsl and nasd.xsl, in the 
heading, a space is needed between "gender" and "smoker" status. 

---------------------------------------------------------
This e-mail transmission may contain information that is 
proprietary, privileged and/or confidential and is 
intended exclusively for the person(s) to whom it is 
addressed. Any use, copying, retention or disclosure by 
any person other than the intended recipient or the 
intended recipient's designees is strictly prohibited. If 
you are not the intended recipient or their designee, 
please notify the sender immediately by return e-mail and 
delete all copies.
---------------------------------------------------------





reply via email to

[Prev in Thread] Current Thread [Next in Thread]