[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fixed ieee1275 console

From: Marcin Kurek
Subject: Re: [PATCH] Fixed ieee1275 console
Date: Mon, 1 Oct 2007 21:43:27 +0200


> Is this a bitmask?  In this case, looks like you aren't using the right
> OTOH if that's what you intended, I think it's better to build one macro
> using the others.

Eeeek, why ? The flags are checked using 'flags & <flag>' as I can see
in kern/term.c, then how (1 << 3) can be evaluated as (1 << 1) and (1
<< 2) in this case ?

> This part doesn't look right.  vesa/vga is a whole different history.  At the
> least vesa *does* support unicode.

But both remaps border codes to cp437 and my code change only this
part, the unicode support is still there I does not touch it.

> Please try to avoid cosmetical changes.

Hmmm, I can not see this change in patch in files I have on my hd :/

> Have you verified that grub-emu still builds / works?

It does not build for ieee1275 on cvs because missing util/hostfs.c in
powerpc-ieee1275.rmk, but after adding it builds/runs fine.

> What is 127 normally?  For firmware bugs, we have a flag mechanism so that it
> only affects the buggy firmware.  Check my latest commit to
> kern/powerpc/ieee1275/cmain.c.

It's DEL key. I placed it here as I saw similar thing in
util/console.c and of coz I verified first that both keys (del &&
backspace) are working correctly on ODW && Efika.

--- Marcin 'Morgoth' Kurek ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]