[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Fixed ieee1275 console

From: Marcin Kurek
Subject: [PATCH] Fixed ieee1275 console
Date: Mon, 1 Oct 2007 12:57:35 +0200


Finaly I found a few free minutes to look at ofconsole as it never
correctly work for me. There was 3 problems on my Pegasos:

1) Backspace key not works with USB keyboard.
2) menu looks ugly like hell as it contains some random characters in
place of borders.
3) Console works wrong (the cursor position was wrong after some
commands eg. ls and it displays only a black hole when grub prints
more than one screen of text)

I am not sure how correct my fix is for non Efika/ODW machines, but I
tested it on both without any problems.

In grub_ofconsole_writeesc() I think it would be good idea to use
single "write" command, but this is a cosmetics only I guess. Also in
grub_ofconsole_getxy() the -1 for grub_curr_x seems to be wrong for

Replaced borders characters in grub_ofconsole_putchar() by '-', '|',
etc. Maybe not perfect, but looks definitly better than before [2].
Also fixed cursor position tracking (grub_curr_x, grub_curr_y) which
fix both console problems [3]

Handle 127 keycode as backspace key in grub_ofconsole_readkey() which fix [1]

BTW Also attach my previous patches with [PATCH] in topic this time.

--- Marcin 'Morgoth' Kurek ---

Attachment: grub2-affs.patch
Description: Text Data

Attachment: grub2-ofboot2.patch
Description: Text Data

Attachment: grub2-ofconsole.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]