Re: [PATCH] Fixed ieee1275 console

[Marco Gerards]

"Marcin Kurek" <address@hidden> writes:

Hi Marcin,

Sorry for the late reply.  I have been absent for quite a while, but I
intend to go over the emails on this list during the weekend
(including yours).  I noticed this email because I worked on this
problem myself, so that is why I am replying now.

> Finaly I found a few free minutes to look at ofconsole as it never
> correctly work for me. There was 3 problems on my Pegasos:
>
> 1) Backspace key not works with USB keyboard.
> 2) menu looks ugly like hell as it contains some random characters in
> place of borders.

Right, this is because it seems that the MSB is lost when writing a
character to the screen.  For the borders specific characters are used
above 127 (non-ASCII).  I wonder if the Pegasos console supports this
ASCII extension if you change some settings or so...

[...]

> Replaced borders characters in grub_ofconsole_putchar() by '-', '|',
> etc. Maybe not perfect, but looks definitly better than before [2].
> Also fixed cursor position tracking (grub_curr_x, grub_curr_y) which
> fix both console problems [3]

I prefer if it can be detected if this is Efika or for example an
apple implementation of OF and handle these characters depending on
that.  IIRC this code does work on the apple, but unfortunately I
cannot check this anymore.

> Handle 127 keycode as backspace key in grub_ofconsole_readkey() which fix [1]

Can you explain this?

--
Marco