[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fixed ieee1275 console

From: Marcin Kurek
Subject: Re: [PATCH] Fixed ieee1275 console
Date: Mon, 1 Oct 2007 20:14:16 +0200


> [...]

OK, split fixes in to separate patches this time as requested.


This is a idea how to handle ascii&&cp473&&utf based menus for
diffrent consoles. I added a two term flags GRUB_TERM_SIMPLE_MENU
(ascii menu) and GRUB_TERM_CP437_MENU (cp437 menus) and handle borders
code remap in kern/term.c/grub_putcode() by using new function

For now GRUB_TERM_CP437_MENU is used in i386/pc/console.c, vesafb.c,
vga.c and GRUB_TERM_SIMPLE_MENU is used in i386/pc/serial.c and in

I think it would be wise to use ascii border codes for OF as there is
no easy way to check the terminal type (serial, screen) and encoding
(on my ODW normal console seems to use cp437, but framebuffer console
seems to be using something else) Anyway ascii menu looks quite nice


Two small things here. First make grub_ofconsole_writeesc() use single
grub_ieee1275_write() call and correct '- 1' in grub_ofconsole_getxy()
... hmmm maybe this should go in to [4]


My OF seems to send 127 for backspace key this patch handle '127' as
backspace. Now I can use it normaly ;)


Fixed cursor x/y position tracking for ofconsole as currect version
definitly doesn't not work as expect to. I am not sure only about
grub_curr_y -= 4; line as my OF scroll the console +4 lines when reach
last line, but is '4' correct for other OF implementations ?

--- Marcin 'Morgoth' Kurek ---

Attachment: 01-grub2-simple_console.patch
Description: Text Data

Attachment: 02-grub2-ofconsole_cosmetic.patch
Description: Text Data

Attachment: 03-grub2-ofconsole_backspace.patch
Description: Text Data

Attachment: 04-grub2-ofconsole_fix.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]