[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Progress on merging Eglot?
From: |
João Távora |
Subject: |
Re: Progress on merging Eglot? |
Date: |
Mon, 19 Sep 2022 15:09:59 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
Payas Relekar <relekarpayas@gmail.com> writes:
> Alright! I think we have everything we need. I took the append URLs to
> bottom of commit message approach. Here's what we have:
>
> - History visible for file lisp/progmodes/eglot.el
> - Commit message length undisturbed
> - every #num is appended with appropriate URL at the bottom of commit
> message
>
> These are the latest and (hopefully) final URLs:
>
> Code:
> https://gist.github.com/bhankas/422c34db2e987d4dc3f243e26ba156a3
>
> (Please ensure eglot2emacs.py is in same directory as eglot/ and emacs/
> repos)
>
> Emacs repo with eglot.el merged:
> https://github.com/bhankas/emacs
>
> eglot.el file history within merged emacs repo:
> https://github.com/bhankas/emacs/commits/master/lisp/progmodes/eglot.el
>
> If all is good, that concludes #2 on João's list.
>
> Let me know for any corrections and/or improvements.
Thanks very much Payas, your work provided a most excellent start.
I took your GitHub gist, forked it, and reworked it. That version now
lives at
https://gist.github.com/joaotavora/2ed97f2ec85958986983d5cb78202770
and I ask that any work proceeds from there.
Most of my work happened in the eglot2emacs.py script, which I have
renamed eglot2emacs-message-callback.py. After many tweaks, I ran it
through git filter-repo and think this version is now my preferred one.
For instance it transforms:
Close #974, #776: Update docstring of eglot-events-buffer-size
* eglot.el (eglot-events-buffer-size): Mention that you need
to<CARRIAGE-RETURN>
restart the connection for 'eglot-events-buffer-size' to take effect.
into
Update docstring of eglot-events-buffer-size
* eglot.el (eglot-events-buffer-size): Mention that you need to
restart the connection for 'eglot-events-buffer-size' to take effect.
GitHub-reference: Close https://github.com/joaotavora/eglot/issues/974
GitHub-reference: Close https://github.com/joaotavora/eglot/issues/776
It also does other small tricks (and maybe some more can be added)
The only problem is that I can't get run the full eglot2emacs.sh to run.
The process is blocked, I think, by an Emacs commit hook that refuses to
accept some trailing changes in some unrelated files. Can you see
what's up with that? Did I mess up eglot2emacs.sh?
João
- Re: Progress on merging Eglot?, (continued)
- Re: Progress on merging Eglot?, Stefan Monnier, 2022/09/18
- Re: Progress on merging Eglot?, Payas Relekar, 2022/09/19
- Re: Progress on merging Eglot?, Payas Relekar, 2022/09/19
- Re: Progress on merging Eglot?, João Távora, 2022/09/19
- Re: Progress on merging Eglot?, Payas Relekar, 2022/09/19
- Re: Progress on merging Eglot?, Payas Relekar, 2022/09/19
- Re: Progress on merging Eglot?, Payas Relekar, 2022/09/19
- Re: Progress on merging Eglot?,
João Távora <=
- Progress on merging Eglot: update, João Távora, 2022/09/23
- Re: Progress on merging Eglot: update, Payas Relekar, 2022/09/24
- Re: Progress on merging Eglot: update, Payas Relekar, 2022/09/24
- Re: Progress on merging Eglot: update, Richard Stallman, 2022/09/24
- Re: Progress on merging Eglot: update, Payas Relekar, 2022/09/25
- Re: Progress on merging Eglot: update, Eli Zaretskii, 2022/09/25
- Re: Progress on merging Eglot: update, Richard Stallman, 2022/09/26
- Re: Progress on merging Eglot: update, João Távora, 2022/09/26
- Re: Progress on merging Eglot: update, Richard Stallman, 2022/09/27
- Re: Progress on merging Eglot?, Stefan Monnier, 2022/09/19