|
From: | Dmitry Gutov |
Subject: | Re: message-mode toolbars, was: Re: "Why is emacs so square?" |
Date: | Fri, 1 May 2020 01:44:38 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 01.05.2020 01:16, Lars Ingebrigtsen wrote:
Oh, it's this bit? (defcustom gmm-tool-bar-style (if (and (boundp 'tool-bar-mode) tool-bar-mode - (and (fboundp 'display-visual-class) - (not (memq (display-visual-class) - (list 'static-gray 'gray-scale - 'static-color 'pseudo-color))))) + (memq (display-visual-class) + (list 'static-gray 'gray-scale + 'static-color 'pseudo-color))) 'gnome 'retro) Oops. Looks like I removed the `not' by mistake while I was cleaning up the foundp test somehow?
Yup.
That's clearly a regression and should be fixed on the emacs-27 branch, I think.
This breakage is from 2016, so it most likely got into Emacs 25.More importantly, while I'm all for fixing bugs, I think fixing it now will be more risky than my icons patch, because gmm-tool-bar-style affects which toolbar is shown. And for message-mode, at least, the 'gnome' and 'retro' toolbars have different contents.
[Prev in Thread] | Current Thread | [Next in Thread] |