emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: emacs-26 8f18d12: Improve documentation of decoding into a unibyte b


From: Stefan Monnier
Subject: Re: emacs-26 8f18d12: Improve documentation of decoding into a unibyte buffer
Date: Wed, 29 May 2019 14:58:57 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

> > I don't think there was much to discuss about it.
> Unilaterally.

Yes, it's was a clear and simple bug-fix, AFAIK.

>> PS: I added checks in encoding/decoding functions to signal errors when
>> decoding from multibyte and encoding from unibyte (in my local Emacs),
>> and that's been tremendously useful to track down and fix encoding bugs
>> in Gnus.
> I have nothing against you making these changes locally to catch
> bugs.  I sometimes do similar things in my locale version of the code.

Yes, and this experience showed me that it's a good practice to follow
(I don't mean "adding checks" but "align unibyte/multibyte with
encoded/decoded").

BTW, I think we should add such checks in `master` (but make them
conditional on a variable like
`check-encoding/decoding-strictly-for-debugging-purposes` which would
of course default to nil).


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]