Re: emacs-26 8f18d12: Improve documentation of decoding into a unibyte buffer

[Eli Zaretskii]

> From: Stefan Monnier <address@hidden>
> Cc: address@hidden
> Date: Tue, 28 May 2019 13:25:17 -0400
> 
> > OK, but how does this affect the issue at hand?  We want to replace
> > string-as-unibyte, or remove it, and the obsolescence message says to
> > replace it with encode-coding-string.
> 
> But this obsolescence message assumes that the call to string-as-unibyte
> was used because of a need to encode the strings using Emacs's internal
> coding-system.  In this case, the string is already encoded (as stated
> by the function's name, the docstring, ...), so using
> encode-coding-string is rather odd.

If the input string is unibyte, then using string-to-unibyte will be
also odd.  And if it's multibyte, the using encode-coding-string is
not really odd, is it?

> I agree that removing the call altogether is the better option.

Right.  In that case we need to document that the function expects as
input either a unibyte string or a pure-ASCII string.