[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 02/22] libqos: Rename i2c_send and i2c_recv
|
From: |
Oleinik, Alexander |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 02/22] libqos: Rename i2c_send and i2c_recv |
|
Date: |
Thu, 19 Sep 2019 13:23:34 +0000 |
On Thu, 2019-09-19 at 13:15 +0200, Paolo Bonzini wrote:
> On 19/09/19 01:19, Oleinik, Alexander wrote:
> > The names i2c_send and i2c_recv collide with functions defined in
> > hw/i2c/core.c. This causes an error when linking against libqos and
> > softmmu simultaneously (for example when using qtest inproc).
> > Rename the
> > libqos functions to avoid this.
>
> I'd prefer "qi2c_{send,recv}" since that is consistent with
> "qvirtio_"
> functions and with the name of the "QI2CDevice" struct.
Ok - i'll change this.
- [Qemu-devel] [PATCH v3 00/22] Add virtual device fuzzing support, Oleinik, Alexander, 2019/09/18
- [Qemu-devel] [PATCH v3 01/22] softmmu: split off vl.c:main() into main.c, Oleinik, Alexander, 2019/09/18
- [Qemu-devel] [PATCH v3 02/22] libqos: Rename i2c_send and i2c_recv, Oleinik, Alexander, 2019/09/18
- [Qemu-devel] [PATCH v3 03/22] fuzz: Add FUZZ_TARGET module type, Oleinik, Alexander, 2019/09/18
- [Qemu-devel] [PATCH v3 04/22] qtest: add qtest_server_send abstraction, Oleinik, Alexander, 2019/09/18
- [Qemu-devel] [PATCH v3 05/22] libqtest: Add a layer of abstraciton to send/recv, Oleinik, Alexander, 2019/09/18
- [Qemu-devel] [PATCH v3 08/22] module: check module wasn't already initialized, Oleinik, Alexander, 2019/09/18