[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 05/22] libqtest: Add a layer of abstraciton to send/recv
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH v3 05/22] libqtest: Add a layer of abstraciton to send/recv |
Date: |
Thu, 19 Sep 2019 16:27:43 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 19/09/19 15:27, Oleinik, Alexander wrote:
> On Thu, 2019-09-19 at 13:18 +0200, Paolo Bonzini wrote:
>> I think you can pass "s" to the tx handler as well, and remove the
>> send_opaque and recv_opaque fields?
>
> Qtest also uses this function to communicate over qmp (different fd).
> I can probably make the tx handler a wrapper which accepts "s", and
> passes s->fd to the real socket_send.
Yes, exactly.
Thanks,
Paolo
- Re: [Qemu-devel] [PATCH v3 02/22] libqos: Rename i2c_send and i2c_recv, (continued)
- [Qemu-devel] [PATCH v3 08/22] module: check module wasn't already initialized, Oleinik, Alexander, 2019/09/18
- [Qemu-devel] [PATCH v3 07/22] fuzz: Add target/fuzz makefile rules, Oleinik, Alexander, 2019/09/18
- [Qemu-devel] [PATCH v3 06/22] fuzz: add configure flag --enable-fuzzing, Oleinik, Alexander, 2019/09/18
- [Qemu-devel] [PATCH v3 09/22] qtest: add in-process incoming command handler, Oleinik, Alexander, 2019/09/18
- [Qemu-devel] [PATCH v3 10/22] tests: provide test variables to other targets, Oleinik, Alexander, 2019/09/18
- [Qemu-devel] [PATCH v3 11/22] libqos: split qos-test and libqos makefile vars, Oleinik, Alexander, 2019/09/18