[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 05/22] libqtest: Add a layer of abstraciton t
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 05/22] libqtest: Add a layer of abstraciton to send/recv |
|
Date: |
Thu, 19 Sep 2019 13:18:50 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 19/09/19 01:19, Oleinik, Alexander wrote:
> +static GString *qtest_client_inproc_recv_line(void *);
This is not defined as of this patch, please move it to patch 14.
>
> + qtest_client_set_rx_handler(s, qtest_client_socket_recv_line, s);
> + qtest_client_set_tx_handler(s, qtest_client_socket_send, &(s->fd));
> +
I think you can pass "s" to the tx handler as well, and remove the
send_opaque and recv_opaque fields?
Paolo
- Re: [Qemu-devel] [PATCH v3 02/22] libqos: Rename i2c_send and i2c_recv, (continued)
- [Qemu-devel] [PATCH v3 08/22] module: check module wasn't already initialized, Oleinik, Alexander, 2019/09/18
- [Qemu-devel] [PATCH v3 07/22] fuzz: Add target/fuzz makefile rules, Oleinik, Alexander, 2019/09/18
- [Qemu-devel] [PATCH v3 06/22] fuzz: add configure flag --enable-fuzzing, Oleinik, Alexander, 2019/09/18
- [Qemu-devel] [PATCH v3 09/22] qtest: add in-process incoming command handler, Oleinik, Alexander, 2019/09/18