[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 02/22] libqos: Rename i2c_send and i2c_recv
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v3 02/22] libqos: Rename i2c_send and i2c_recv |
Date: |
Thu, 19 Sep 2019 11:05:51 +0100 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
On Wed, Sep 18, 2019 at 11:19:29PM +0000, Oleinik, Alexander wrote:
> The names i2c_send and i2c_recv collide with functions defined in
> hw/i2c/core.c. This causes an error when linking against libqos and
> softmmu simultaneously (for example when using qtest inproc). Rename the
> libqos functions to avoid this.
>
> Signed-off-by: Alexander Oleinik <address@hidden>
> ---
> tests/libqos/i2c-imx.c | 8 ++++----
> tests/libqos/i2c-omap.c | 8 ++++----
> tests/libqos/i2c.c | 10 +++++-----
> tests/libqos/i2c.h | 4 ++--
> tests/pca9552-test.c | 10 +++++-----
> 5 files changed, 20 insertions(+), 20 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH v3 00/22] Add virtual device fuzzing support, Oleinik, Alexander, 2019/09/18
- [Qemu-devel] [PATCH v3 01/22] softmmu: split off vl.c:main() into main.c, Oleinik, Alexander, 2019/09/18
- [Qemu-devel] [PATCH v3 02/22] libqos: Rename i2c_send and i2c_recv, Oleinik, Alexander, 2019/09/18
- [Qemu-devel] [PATCH v3 03/22] fuzz: Add FUZZ_TARGET module type, Oleinik, Alexander, 2019/09/18
- [Qemu-devel] [PATCH v3 04/22] qtest: add qtest_server_send abstraction, Oleinik, Alexander, 2019/09/18
- [Qemu-devel] [PATCH v3 05/22] libqtest: Add a layer of abstraciton to send/recv, Oleinik, Alexander, 2019/09/18