[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 01/22] softmmu: split off vl.c:main() into ma
|
From: |
Oleinik, Alexander |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 01/22] softmmu: split off vl.c:main() into main.c |
|
Date: |
Thu, 19 Sep 2019 13:01:49 +0000 |
On Thu, 2019-09-19 at 11:03 +0100, Stefan Hajnoczi wrote:
> On Wed, Sep 18, 2019 at 11:19:28PM +0000, Oleinik, Alexander wrote:
> > #ifdef CONFIG_COCOA
> > #undef main
>
> This looks suspicious. Should the #ifdef CONFIG_COCOA be moved into
> main.c?
> The return value is confusing. 0 = success, >0 error exit code, but
> the
> function may also invoke exit(0) to terminate successfully.
>
> It's simpler to make this function void and invoke exit(3) directly.
I'll make these changes. Thanks
- [Qemu-devel] [PATCH v3 00/22] Add virtual device fuzzing support, Oleinik, Alexander, 2019/09/18
- [Qemu-devel] [PATCH v3 01/22] softmmu: split off vl.c:main() into main.c, Oleinik, Alexander, 2019/09/18
- [Qemu-devel] [PATCH v3 02/22] libqos: Rename i2c_send and i2c_recv, Oleinik, Alexander, 2019/09/18
- [Qemu-devel] [PATCH v3 03/22] fuzz: Add FUZZ_TARGET module type, Oleinik, Alexander, 2019/09/18
- [Qemu-devel] [PATCH v3 04/22] qtest: add qtest_server_send abstraction, Oleinik, Alexander, 2019/09/18
- [Qemu-devel] [PATCH v3 05/22] libqtest: Add a layer of abstraciton to send/recv, Oleinik, Alexander, 2019/09/18