Re: [PATCH 39/71] target/arm: Add SVL to TB flags

[Richard Henderson]

On 6/7/22 02:58, Peter Maydell wrote:
> > @@ -3292,6 +3292,7 @@ FIELD(TBFLAG_A64, MTE0_ACTIVE, 19, 1)
> >   FIELD(TBFLAG_A64, SMEEXC_EL, 20, 2)
> >   FIELD(TBFLAG_A64, PSTATE_SM, 22, 1)
> >   FIELD(TBFLAG_A64, PSTATE_ZA, 23, 1)
> > +FIELD(TBFLAG_A64, SVL, 24, 4)
>
> Given that both SVE and SME start with an 'S', maybe
> "SME_VL" would be less prone to confusion? On the other hand,
> SVL is the architectural name, so maybe that's best.

Yeah, my first version used SME_LEN, but in the end I thought using the architectural name 
was best.  Just above, there's commentary using the other architectural names "VL" and "NVL".

> > +static inline int sme_vq_cached(CPUARMState *env)
>
> Same remark as earlier about not needing to put "cached" in the function name.

Already fixed.  :-)


r~