Re: [PATCH 37/71] target/arm: Add cpu properties for SME

[Richard Henderson]

On 6/7/22 02:47, Peter Maydell wrote:
> > +void arm_cpu_sme_finalize(ARMCPU *cpu, Error **errp)
> > +{
> > +    uint32_t vq_map = cpu->sme_vq.map;
> > +    uint32_t vq_init = cpu->sme_vq.init;
> > +    uint32_t vq_supported = cpu->sme_vq.supported;
> > +    uint32_t vq;
> > +
> > +    if (vq_map == 0) {
> > +        if (!cpu_isar_feature(aa64_sme, cpu)) {
> > +            cpu->isar.id_aa64smfr0 = 0;
> > +            return;
> > +        }
> > +
> > +        /* TODO: KVM will require limitations via SMCR_EL2. */
> > +        vq_map = vq_supported & ~vq_init;
>
> Do we currently forbid setting these properties entirely for KVM
> (or just not provide them) ?

I do not provide them.

> These new properties should be documented in
> docs/system/arm/cpu-features.rst, similar to the SVE ones.

Oops, yes.


r~