Re: [Partysip-dev] loop detection

[Aymeric Moizard]

I'm testing first the indentation but already got some issue:

indent partysip/partysip.h
converts the following:

void        psp_core_remove_all_hook();
void        psp_core_remove_all_plugins();
PPL_DECLARE(char *)      psp_core_get_ip_of_local_proxy();
PPL_DECLARE(int)         psp_core_get_port_of_local_proxy();
PPL_DECLARE(int)         psp_core_is_responsible_for_this_domain(url_t
*url);
PPL_DECLARE(int)
psp_core_is_responsible_for_this_request_uri(url_t *url);
PPL_DECLARE(int)         psp_core_is_responsible_for_this_route(url_t
*url);
int         psp_core_slp_new_branch(slp_branch_t **sl, psp_req_t
*request);
int         psp_core_sfp_new_rsp_ctx(rsp_ctx_t **ctx, psp_req_t *req);
char       *psp_core_slp_generate_branch_for_request(sip_t *request);
char       *psp_core_sfp_generate_branch_for_request(sip_t *request);
psp_req_t  *psp_core_slp_find_req(char *branch);
psp_req_t  *psp_core_sfp_find_req(int osip_id);

to:

void psp_core_remove_all_hook ();
void psp_core_remove_all_plugins ();
PPL_DECLARE (char *)
psp_core_get_ip_of_local_proxy ();
PPL_DECLARE (int)
psp_core_get_port_of_local_proxy ();
PPL_DECLARE (int)
psp_core_is_responsible_for_this_domain (url_t * url);
PPL_DECLARE (int)
psp_core_is_responsible_for_this_request_uri (url_t * url);
PPL_DECLARE (int)
psp_core_is_responsible_for_this_route (url_t * url);
     int psp_core_slp_new_branch (slp_branch_t ** sl, psp_req_t *
request);
     int psp_core_sfp_new_rsp_ctx (rsp_ctx_t ** ctx, psp_req_t * req);
     char *psp_core_slp_generate_branch_for_request (sip_t * request);
     char *psp_core_sfp_generate_branch_for_request (sip_t * request);
     psp_req_t *psp_core_slp_find_req (char *branch);
     psp_req_t *psp_core_sfp_find_req (int osip_id);

The method above should begin at the beginning of the lines, but
a tabulation appears before it. Also, all lines starting with
PPL_DECLARE(...) are moved to 2 lines even if those lines are
smaller than "95".

Don't know how to deal with that! Any idea?
Aymeric


On Wed, 4 Sep 2002, Fredrik Thulin wrote:

> On Tuesday 03 September 2002 15.04, Aymeric Moizard wrote:
> ...
> > You're not the only one that complains about my indentation.
> > I'm not against moving to indent. Give me some tips to start with it.
>
> after looking at it for a few minutes, this .indent.pro creates code that i
> wouldn't say differ too much from yours (but of course you have to check,
> because i don't know all the details in your indentation ;) ) :
>
> --gnu-style
> --indent-level 2
> --blank-lines-after-declarations
> --blank-lines-after-procedures
> --cuddle-else
> --space-special-semicolon
> --no-blank-before-sizeof
> --no-space-after-parentheses
> --continue-at-parentheses
> --line-length95
> --comment-line-length80
> --honour-newlines
> --case-indentation 2
> --space-after-cast
> --space-after-for
> --space-after-if
> --space-after-while
>
> (and in case you are curious, that is the same as i normally use but i have
> --indent-level 8 and --case-indentation 8, plus i have --braces-on-if-line).
>
> the above is GNU indent (2.2.7). i beleive BSD indent are slightly different.
>
> to try it out, just put the above in your ~/.indent.pro. if you decide to
> start indenting partysip with it, i think one of these files ought to go into
> each directory in the source (containing .{c,h} files).
>
> > > Also, making patches would be much easier if all the autogenerated files
> > > were not in CVS.
> ...
> > If you think that it can help, why not.
>
> i really like your attitude ;) i'll have a look at it as soon as i get some
> spare cycles.
>
> > Also, there are options for diff so it does not compare some files:
> > diff -x *.am -x *.in -r dir1 dir2
>
> that doesn't work with 'cvs diff' unfortunately. i tried putting Makefile.in
> in .cvsignore files in my cvs copy but that didn't work either.
>
> /Fredrik
>