Re: [Mingw-cross-env-list] [PATCH] FFmpeg: add missing dependencies to pkgconfig files

[Martin Lambers]

Hi Mark!

On Sat, 10 Mar 2012 21:19:23 +0100, Mark Brand wrote:
> >> 3. It would be nice if the patches actually were cherry-picked from
> >> the ffmpeg git repo. Something like this:
> >> [...]
> > Sorry, but I really think that's overkill, because this is clearly a
> > one-shot patch: issue 1 is already fixed upstream, and issue 2
> > already has a tested patch, so it is clear that we can drop the
> > patch for the next FFmpeg version.
> >
> > Wouldn't it be sufficient to add a comment to this effect in the
> > patch header? A suggestion is applied.
> 
> You have a point and I don't want to make you do a lot of extra work
> for those 2 lines. On the other hand, I think git is really an
> excellent tool for preparing even the simplest of patches once you
> get the hang of it, and especially when the package in question uses
> git.
> 
> Cherry-picking from the official repo has more advantages than just 
> making it easier to fit the patch onto the next version. One reason I 
> like to check the package repo is that the commit in the repo might
> be an improvement on my own quick fix. Also, I might end up having to
> fix more things later on and if I've used commits from the repo as
> much as possible, additional cherry-picked commits are more likely to
> apply cleanly.
> 
> Having said that, I don't really object to accepting your patch
> as-is. Thanks!

Thank you. Issue 2 (libavdevice.pc) is now also fixed upstream:
6cb89df84596af0939a00496b381bcaa013ba929.

I agree with your view on managing patches with git; I just think that
the overhead is a little too much for small and simple one-shot
patches. But I will keep it in mind for future patches.

Martin