Re: [Mingw-cross-env-list] [PATCH] FFmpeg: add missing dependencies to pkgconfig files

[Mark Brand]

> > 2. You mention libswresample and libavfilter, but the patch actually
> > affects libavdevice and libavfilter.
> The patch adds libavfilter to libavdevice.pc, and libswresample to
> libavfilter.pc, as intended.

Thanks for the clarification. I overlooked that.

> > 3. It would be nice if the patches actually were cherry-picked from
> > the ffmpeg git repo. Something like this:
> > [...]
> Sorry, but I really think that's overkill, because this is clearly a
> one-shot patch: issue 1 is already fixed upstream, and issue 2 already
> has a tested patch, so it is clear that we can drop the patch for the
> next FFmpeg version.
>
> Wouldn't it be sufficient to add a comment to this effect in the patch
> header? A suggestion is applied.

You have a point and I don't want to make you do a lot of extra work for 
those 2 lines. On the other hand, I think git is really an excellent 
tool for preparing even the simplest of patches once you get the hang of 
it, and especially when the package in question uses git.

Cherry-picking from the official repo has more advantages than just 
making it easier to fit the patch onto the next version. One reason I 
like to check the package repo is that the commit in the repo might be 
an improvement on my own quick fix. Also, I might end up having to fix 
more things later on and if I've used commits from the repo as much as 
possible, additional cherry-picked commits are more likely to apply cleanly.

Having said that, I don't really object to accepting your patch as-is. 
Thanks!

changeset:   2271:9bf115e96cfd
tag:         tip
user:        Martin Lambers <address@hidden>
date:        Sat Mar 10 20:00:28 2012 +0100
summary:     Add missing entries to FFmpeg pkgconfig files.


Mark