Re: [Mingw-cross-env-list] [PATCH] FFmpeg: add missing dependencies to pkgconfig files

[Martin Lambers]

Hi Mark!

Thanks for having a look at the patch.

On Sat, 10 Mar 2012 10:32:09 +0100, Mark Brand wrote:
> > The attached patch fixes FFmpeg's libavfilter.pc and libavdevice.pc
> > files.
> >
> > The first lacks an entry for libswresample, the second lacks an
> > entry for libavfilter. The first issue is already fixed upstream,
> > the second is reported as upstream ticket #1050.
> 
> Thanks for working on this. I have a few suggestions and questions.
> 
> 1. The patch should have the standard header found in the other 
> src/*.patch files. You don't need the "taken from" bit in the header
> if patches in the file have their own git-style headers that make the 
> provenance clear.

OK.

> 2. You mention libswresample and libavfilter, but the patch actually 
> affects libavdevice and libavfilter.

The patch adds libavfilter to libavdevice.pc, and libswresample to
libavfilter.pc, as intended.

> 3. It would be nice if the patches actually were cherry-picked from
> the ffmpeg git repo. Something like this:
> [...]

Sorry, but I really think that's overkill, because this is clearly a
one-shot patch: issue 1 is already fixed upstream, and issue 2 already
has a tested patch, so it is clear that we can drop the patch for the
next FFmpeg version.

Wouldn't it be sufficient to add a comment to this effect in the patch
header? A suggestion is applied.

Best regards,
Martin

ffmpeg-fix-pkgconfig.patch
Description: Text Data