Re: [Enigma-devel] Maemo Port for Nokia Internet Tablets

[Tacvek]

----- Original Message ----- 
From: "Pipeline" <address@hidden>
To: "Pipeline" <address@hidden>
Cc: "Ronald Lamprecht" <address@hidden>; <address@hidden>; 
<address@hidden>
Sent: Thursday, February 14, 2008 10:20 PM
Subject: Re: [Enigma-devel] Maemo Port for Nokia Internet Tablets

> > Heres my first attempt at a diff file, which i manually cleaned up so i 
> > hope its machine readable, otherwise its human readable.  Perhaps you can 
> > integrate the global variables through some sort of build configuration.
> >
> > ftp://wardenclyffetower.com/wwwroot/MaemoFiles/source/enigma_maemo_mods.diff
>
> Sorry, correction :
> http://wardenclyffetower.com/MaemoFiles/source/enigma_maemo_mods.diff


Ok. A first look at this raises only minor issues.
First one is that following change may cause some problems:
-        case SDL_MOUSEBUTTONDOWN:
+        case SDL_MOUSEBUTTONDOWN: break;

On most systems, that fall-through was important, so Enigma would know when 
the mouse button was released.

Second, the current code looks to have no meathod of simulating the holding 
down the primary mouse button feature, which allows one to avoid picking up 
undesireable items.
I'm not sure if this would make any level unsolvable, but it can definately 
increase the difficulty of some levels. It would be nice to be able to 
properly include that ability in the port.

It would probably preferable to have the TOUCHSCREEN_MULTIPLE macro be 
replaced with a user configurable variable.

Then there is a bit of stylistic cleanup to be done during integration,
as well as adding the macros to the build system.