Re: scratch/igc: Implications of MPS being asynchronous

[Gerd Möllmann]

Stefan Kangas <stefankangas@gmail.com> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> From: Stefan Kangas <stefankangas@gmail.com>
>>> Date: Sun, 12 Jan 2025 16:55:54 +0000
>>> Cc: pipcet@protonmail.com, emacs-devel@gnu.org, gerd@gnu.org,
>>>     eller.helmut@gmail.com
>>>
>>> (IMHO, the code organization is a bit funny here, because
>>> garbage_collect() doesn't do what it says on the tin.  I don't think
>>> it's worth addressing that right now though.  Maybe it's worth taking a
>>> second look after merging.)
>>
>> If we want to add igc_collect somewhere which is called by
>> garbage-collect, we should add it to garbage_collect, because what you
>> call "funny" here is quite confusing.  Are there any good reasons not
>> to call igc_collect from garbage_collect?
>
> AFAIU, MPS should decide when to GC, not maybe_gc.

Maybe I'm misunderstanding something and I haven't read all my mails
yet, but if this is about calling igc_collect (= mps_arena_collect) in
some regular code path, I find that a very bad idea. It works against
MPS as a incremental + generational GC.

Strange idea. But what do I know :-)