Re: Scroll bars on macOS builds

[Angelo Graziosi]

> Il 27/01/2022 20:59 Alan Third ha scritto:
> 
>  
> On Wed, Jan 26, 2022 at 06:07:24PM +0100, Angelo Graziosi wrote:
> > > Il 26/01/2022 00:01 Alan Third ha scritto:
> > > 
> > > 
> > > Can you try changing line 7198 in nsterm.m from
> > > 
> > >   [self setWantsLayer:YES];
> > > 
> > > to
> > > 
> > >   [self setWantsLayer:NO];
> > > 
> > > ?
> > 
> > Emacs crashes at startup. I have rebuilt Emacs from current master and from 
> > master-20220111 with your suggestions but it wont start!
> > 
> > Attached the bug report it want to send to Apple people...
> 
> Actually, can you try this again, but remove the call to flushWindow
> in unlockFocus (line 7902)? I've a feeling that's a GNUstep method
> that's accidentally crept into the Cocoa code.

I have built current master with patch (do you mean it?) below and it works, 
i.e. scrollbars are visible!

--- nsterm.m.orig       2022-01-27 22:26:12.000000000 +0100
+++ nsterm.m    2022-01-27 22:44:59.000000000 +0100
@@ -7195,7 +7195,7 @@
      on resize.  Unfortunately it also means the frame will not be
      automatically marked for display, but we can do that ourselves in
      resizeWithOldSuperviewSize.  */
-  [self setWantsLayer:YES];
+  [self setWantsLayer:NO];
   [self setLayerContentsRedrawPolicy:
           NSViewLayerContentsRedrawOnSetNeedsDisplay];
   [self setLayerContentsPlacement:NSViewLayerContentsPlacementTopLeft];
@@ -7899,7 +7899,6 @@
   else
     {
       [super unlockFocus];
-      [super flushWindow];
     }
 #endif
 }