emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Unicode combining characters


From: Basil L. Contovounesios
Subject: Re: Unicode combining characters
Date: Thu, 27 May 2021 11:34:55 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Eli Zaretskii <eliz@gnu.org> writes:

> OK, I improved this case now on master, please take a look

I'm seeing a couple of warnings:

character.c: In function ‘lisp_string_width’:
character.c:397:16: warning: assignment to ‘int’ from ‘Lisp_Object’
  {aka ‘struct Lisp_X *’} makes integer from pointer without a cast
  [-Wint-conversion]
  397 |     font_width = AREF (font_info, 11);
      |                ^
character.c:398:19: warning: ordered comparison of pointer with integer
  zero [-Wextra]
  398 |     if (font_info <= 0)
      |                   ^~
character.c:399:18: warning: assignment to ‘int’ from ‘Lisp_Object’ {aka
  ‘struct Lisp_X *’} makes integer from pointer without a cast
  [-Wint-conversion]
  399 |       font_width = AREF (font_info, 10);

Do the font_info elements need to be untagged, and font_width rather
than font_info checked for being positive?

Thanks,

-- 
Basil

gcc (Debian 10.2.1-6) 10.2.1 20210110



reply via email to

[Prev in Thread] Current Thread [Next in Thread]