Re: Proposed changes to gnus-dup.el

[Andy Moreton]

On Mon 25 Mar 2019, Basil L. Contovounesios wrote:

> Stefan Monnier <address@hidden> writes:
>
>>>> While looking into bug#34973, bug#34974, and bug#34987, I accumulated
>>>> the attached changes to lisp/gnus/gnus-dup.el which I would like to push
>>>> to master.  WDYT?
>>>
>>> Given the games Gnus plays with bindings (see `defvoo' and `deffoo') the
>>> switch to lexical binding for gnus may prove to be complex.
>>>
>>> It would be better to avoid switching to lexical binding for a single
>>> file in gnus: rather, do that as part of a larger effort to switch all
>>> of gnus over to lexical binding.
>>
>> FWIW, I've been compiling Gnus using lexical-binding for many years now,
>> and it's the MUA I use to spam this mailing-list, so at least the main
>> "read&write messages" works fine for the nnimap and nntp backends.
>>
>> I think the def[fv]oo hacks don't get in the way of
>> lexical-binding at all.
>
> Thank you for sharing your experience; it's reassuring.

I am glad to hear that lexical binding is not problematic after all.
Perhaps you can coordinate with Stephan to update all of Gnus to use
lexical binding ?

Thanks for working on Gnus,

    AndyM