Re: Proposed changes to gnus-dup.el

[Basil L. Contovounesios]

Andy Moreton <address@hidden> writes:

> On Mon 25 Mar 2019, Basil L. Contovounesios wrote:
>
>> While looking into bug#34973, bug#34974, and bug#34987, I accumulated
>> the attached changes to lisp/gnus/gnus-dup.el which I would like to push
>> to master.  WDYT?
>
> Given the games Gnus plays with bindings (see `defvoo' and `deffoo') the
> switch to lexical binding for gnus may prove to be complex.

There are no such binding constructs in gnus-dup.el, and switching to
lexical-binding in this file was simple, as the patch demonstrates.

> It would be better to avoid switching to lexical binding for a single
> file in gnus: rather, do that as part of a larger effort to switch all
> of gnus over to lexical binding.

Why would that be better?

Enabling lexical-binding in a small, simple file carries little risk of
fallout while providing the (admittedly tiny) benefit of bringing us one
increment closer to lexical Gnus.

Sweeping changes across the whole Gnus system, OTOH, are far more risky,
as the recent switch to hash-tables has taught us.

I would welcome such a wholesale switch to lexical-binding, but I see no
reason or benefit to hold back on one file in the meantime.

Thanks,

-- 
Basil