emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Proposed changes to gnus-dup.el


From: Basil L. Contovounesios
Subject: Re: Proposed changes to gnus-dup.el
Date: Mon, 25 Mar 2019 18:13:46 +0000
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Lars Ingebrigtsen <address@hidden> writes:

> "Basil L. Contovounesios" <address@hidden> writes:
>
>> +      (unless (or (gnus-data-pseudo-p datum)
>> +                  (<= (gnus-data-number datum) 0)
>
> I'm against using `unless' on complex logic -- many people get confused
> when reading it in my experience.

Fair enough.

> The rest looks OK.

Thanks.  I will wait a few more days for people to comment and push the
rest of the patch if there are no serious objections.

-- 
Basil



reply via email to

[Prev in Thread] Current Thread [Next in Thread]