RE: [avr-libc-dev] Nice to have: XCK Definition

[Weddington, Eric]

Hi Frédéric,

The vector number names in your patch should have a different format, like so:
INT0_vect_num

It should be <name>_vect_num. This is the format that newer header files are 
using.

In reviewing this, I still have a hard time with this format:
+#define DDR_SS         DDRB
+#define PORT_SS        PORTB
+#define PIN_SS         PINB
+#define SS_IDX         0

I think that it will be frustrating to the user that the format is:
DDR_<name>
PORT_<name>
PIN_<name>
<name>_IDX

It's inconsistent. Are there any clues that we can derive from the datasheets 
about the index value?

In a way I actually prefer the <name>_<function> format, even if it doesn't 
match the datasheet. It's easier to remember as the naming scheme resembles OO 
constructs.

Does anyone else have a preference?

BTW, thanks again Frédéric for doing the work on this. I know there's a lot of 
header files to cover.

Eric Weddington
 

> -----Original Message-----
> From: 
> address@hidden 
> [mailto:address@hidden
> org] On Behalf Of Frédéric Nadeau
> Sent: Thursday, March 26, 2009 5:01 PM
> To: address@hidden
> Subject: Re: [avr-libc-dev] Nice to have: XCK Definition
> 
> I posted my patch on bug report:
> bug #25300: Additional i/o port names
> 
> If applyed againt avr-libc/HEAD it will include the vector and pin
> description to most header.
> 
> Frédéric
> 
> On Thu, Mar 26, 2009 at 6:51 PM, Ron Kreymborg 
> <address@hidden> wrote:
> >> > /* External Interrupt Request 5 */
> >> > #define INT5_num                     6
> >> > #define INT5_vect                     _VECTOR(6)
> >> > #define SIG_INTERRUPT5                 _VECTOR(6)
> >> >
> >> > Note that SIG_xxxx and yyyy_vect are not always aligned. 
> yyyy_vect
> >> and
> >> > yyyy_num however are always aligned.
> >>
> >> I'd like to see a final patch before it is committed.
> >
> > My original patch was ready to go apart from the headers. 
> However that was a
> > few versions ago. I'll download the latest versions and 
> check if the patch
> > needs any changes.
> >
> > Ron
> >
> >
> >
> >
> > _______________________________________________
> > AVR-libc-dev mailing list
> > address@hidden
> > http://lists.nongnu.org/mailman/listinfo/avr-libc-dev
> >
> 
> 
> _______________________________________________
> AVR-libc-dev mailing list
> address@hidden
> http://lists.nongnu.org/mailman/listinfo/avr-libc-dev
>