autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 04/12] use a shell function for _AC_RUN_IFELSE


From: Paolo Bonzini
Subject: Re: [PATCH 04/12] use a shell function for _AC_RUN_IFELSE
Date: Thu, 23 Oct 2008 11:04:49 +0200
User-agent: Thunderbird 2.0.0.17 (Macintosh/20080914)

Ralf Wildenhues wrote:
> * Eric Blake wrote on Thu, Oct 23, 2008 at 04:46:39AM CEST:
>> According to Ralf Wildenhues on 10/22/2008 2:34 PM:
>>> While I haven't looked at this in detail, I do know there are places in
>>> Autoconf where removing the output files before evaluating the actions
>>> breaks user scripts.  So this sounds quite unsafe to me.

Good catch.

> You may also want to take note that some scripts use 'break' or even
> 'break 2' to get out of some tests early; unfortunately, this is even
> documented in the manual in some places.  I see that of course we don't
> exercise this in our test suite  :-/
> but its semantics may be relevant for your patches (or not; haven't
> checked).

No, that's safe.  The only hiccup is the reordering of rm's vs. actions,
but the depth of loops is the same before and after the patches.  By the
way, I have no problem in putting the rm entirely outside of the shell
function, of course.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]