autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 04/12] use a shell function for _AC_RUN_IFELSE


From: Eric Blake
Subject: Re: [PATCH 04/12] use a shell function for _AC_RUN_IFELSE
Date: Mon, 27 Oct 2008 06:18:53 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.17) Gecko/20080914 Thunderbird/2.0.0.17 Mnenhy/0.7.5.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Ralf Wildenhues on 10/26/2008 3:04 AM:
>> +    (_AC_RUN_LOG): Avoid subshell for logging.
>> +
> 
>> --- a/lib/autoconf/general.m4
>> +++ b/lib/autoconf/general.m4
>> @@ -2230,7 +2230,7 @@ AU_ALIAS([AC_VERBOSE], [AC_MSG_RESULT])
>>  # ----------------------------------
>>  # Eval COMMAND, save the exit status in ac_status, and log it.
>>  AC_DEFUN([_AC_RUN_LOG],
>> -[{ ($2) >&AS_MESSAGE_LOG_FD
>> +[{ { $2; } >&AS_MESSAGE_LOG_FD
> 
> This breaks Ultrix compatibility (when used as part of AC_TRY_EVAL), no?

Perhaps, but our testsuite already broke Ultrix compatibility, and no one
has complained:
http://git.savannah.gnu.org/gitweb/?p=autoconf.git;a=commitdiff;h=755596

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkkFsa0ACgkQ84KuGfSFAYBn6gCgr4KbQWLYCAUglaFM7D6VMwrF
OZgAoIqXJ6abEotZ8NQ1lY+87QBQg9un
=DVMq
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]