Re: [PATCH 04/12] use a shell function for _AC_RUN_IFELSE

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Ralf Wildenhues on 10/22/2008 2:34 PM:
> Hello Eric, Paolo,
> 
> * Eric Blake wrote on Wed, Oct 22, 2008 at 07:59:08PM CEST:
>> This is a subtle change in semantics; beforehand, the if-failed code
>> ($3) was executed while the compiler output still existed, and could
>> theoretically rerun conftest$ac_exeext with an argument; now the files
>> are removed before the if- failed code is run.  Was this intentional?
>> IMHO, it is a harmless change
> 
> While I haven't looked at this in detail, I do know there are places in
> Autoconf where removing the output files before evaluating the actions
> breaks user scripts.  So this sounds quite unsafe to me.

For that matter, the current refactoring results in more rm processes than
before.  Maybe it is worth making _AC_COMPILE_IFELSE_BODY and friends
merely set a shell variable with the list of files to rm, then call a
single rm after the AS_IF has completed the if-pass/if-fail actions of
ac_func_c_try_compile?  Also, the 'rm -rf conftest.dSYM' is a wasted fork
on most platforms (particularly on those like cygwin where forks are
expensive); should we add a 'test -d conftest.dSYM' first?

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkj/5Y8ACgkQ84KuGfSFAYDlXACfc5ujLomwjHwPBO8WbjNpKPlI
peEAnitar0EL+RWzlWXlziz8gHCP3nTH
=Pzxv
-----END PGP SIGNATURE-----