[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: wget2 | Draft: Small fixes (!505)
From: |
Avinash Sonawane (@rootkea) |
Subject: |
Re: wget2 | Draft: Small fixes (!505) |
Date: |
Mon, 06 Jun 2022 10:28:47 +0000 |
Avinash Sonawane commented on a discussion on unit-tests/test.c:
https://gitlab.com/gnuwget/wget2/-/merge_requests/505#note_972279039
> }
>
> for (it = 0; it < sizeof(string); it++)
> {
> - memset(string, 'a', it);
> - string[it] = 0;
> + if (it > 0)
Ah, indeed! I missed the outer `for` loops. Not just 1 but 4!
Anyways, I think `memset(string, 0, sizeof(string))` once before the loop is
okay than having `memset(string, 'a', it)` in inner loop executing repeatedly.
--
Reply to this email directly or view it on GitLab:
https://gitlab.com/gnuwget/wget2/-/merge_requests/505#note_972279039
You're receiving this email because of your account on gitlab.com.
- Re: wget2 | Draft: Small fixes (!505),
Avinash Sonawane (@rootkea) <=
- Re: wget2 | Draft: Small fixes (!505), Avinash Sonawane (@rootkea), 2022/06/06
- Re: wget2 | Draft: Small fixes (!505), Avinash Sonawane (@rootkea), 2022/06/06
- Re: wget2 | Draft: Small fixes (!505), Avinash Sonawane (@rootkea), 2022/06/06
- Re: wget2 | Draft: Small fixes (!505), Avinash Sonawane (@rootkea), 2022/06/06
- Re: wget2 | Draft: Small fixes (!505), Avinash Sonawane (@rootkea), 2022/06/07
- Re: wget2 | Draft: Small fixes (!505), Avinash Sonawane (@rootkea), 2022/06/22