Re: wget2 | Draft: Small fixes (!505)

[Avinash Sonawane (@rootkea)]

Avinash Sonawane commented on a discussion on unit-tests/test.c: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/505#note_1000975956

>       CHECK(!wget_memdup(NULL, 4));
>       CHECK(p = wget_memdup("xxx", 0)); xfree(p);
>       CHECK(p = wget_memdup("xxx", 4));
> -     CHECK(!memcmp(p, "xxx", 4)); xfree(p);
> +     if (p) {

Done.

> It doesn't fail in our CI, or does it ?

No, it doesn't. Because 
[`Scan-Build/Debian`](https://gitlab.com/gnuwget/wget2/-/blob/master/.gitlab-ci.yml#L260)
 job only does `make` and not `make check`.

I'm updating .gitlab-ci.yml adding `make check`.

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/505#note_1000975956
You're receiving this email because of your account on gitlab.com.